view MasterLoop.c @ 186:69eb54ce9c4b

fix uninitialised semantic Data bug
author Nina Engelhardt <nengel@mailbox.tu-berlin.de>
date Tue, 31 Jan 2012 18:30:35 +0100
parents 28cc465f7eb7
children fe5ad5726e36
line source
1 /*
2 * Copyright 2010 OpenSourceStewardshipFoundation
3 *
4 * Licensed under BSD
5 */
9 #include <stdio.h>
10 #include <stddef.h>
12 #include "VMS.h"
13 #include "ProcrContext.h"
16 //===========================================================================
17 void inline
18 stealWorkInto( SchedSlot *currSlot, VMSQueueStruc *readyToAnimateQ,
19 VirtProcr *masterPr );
21 //===========================================================================
25 /*This code is animated by the virtual Master processor.
26 *
27 *Polls each sched slot exactly once, hands any requests made by a newly
28 * done slave to the "request handler" plug-in function
29 *
30 *Any slots that need a virt procr assigned are given to the "schedule"
31 * plug-in function, which tries to assign a virt procr (slave) to it.
32 *
33 *When all slots needing a processor have been given to the schedule plug-in,
34 * a fraction of the procrs successfully scheduled are put into the
35 * work queue, then a continuation of this function is put in, then the rest
36 * of the virt procrs that were successfully scheduled.
37 *
38 *The first thing the continuation does is busy-wait until the previous
39 * animation completes. This is because an (unlikely) continuation may
40 * sneak through queue before previous continuation is done putting second
41 * part of scheduled slaves in, which is the only race condition.
42 *
43 */
45 /*May 29, 2010 -- birth a Master during init so that first core loop to
46 * start running gets it and does all the stuff for a newly born --
47 * from then on, will be doing continuation, but do suspension self
48 * directly at end of master loop
49 *So VMS__init just births the master virtual processor same way it births
50 * all the others -- then does any extra setup needed and puts it into the
51 * work queue.
52 *However means have to make masterEnv a global static volatile the same way
53 * did with readyToAnimateQ in core loop. -- for performance, put the
54 * jump to the core loop directly in here, and have it directly jump back.
55 *
56 *
57 *Aug 18, 2010 -- Going to a separate MasterVP for each core, to see if this
58 * avoids the suspected bug in the system stack that causes bizarre faults
59 * at random places in the system code.
60 *
61 *So, this function is coupled to each of the MasterVPs, -- meaning this
62 * function can't rely on a particular stack and frame -- each MasterVP that
63 * animates this function has a different one.
64 *
65 *At this point, the masterLoop does not write itself into the queue anymore,
66 * instead, the coreLoop acquires the masterLock when it has nothing to
67 * animate, and then animates its own masterLoop. However, still try to put
68 * several AppVPs into the queue to amortize the startup cost of switching
69 * to the MasterVP. Note, don't have to worry about latency of requests much
70 * because most requests generate work for same core -- only latency issue
71 * is case when other cores starved and one core's requests generate work
72 * for them -- so keep max in queue to 3 or 4..
73 */
74 void masterLoop( void *initData, VirtProcr *animatingPr )
75 {
76 int32 slotIdx, numSlotsFilled;
77 VirtProcr *schedVirtPr;
78 SchedSlot *currSlot, **schedSlots;
79 MasterEnv *masterEnv;
80 VMSQueueStruc *readyToAnimateQ;
82 SlaveScheduler slaveScheduler;
83 RequestHandler requestHandler;
84 void *semanticEnv;
86 int32 thisCoresIdx;
87 VirtProcr *masterPr;
88 volatile VirtProcr *volatileMasterPr;
90 volatileMasterPr = animatingPr;
91 masterPr = (VirtProcr*)volatileMasterPr; //used to force re-define after jmp
93 //First animation of each MasterVP will in turn animate this part
94 // of setup code.. (VP creator sets up the stack as if this function
95 // was called normally, but actually get here by jmp)
96 //So, setup values about stack ptr, jmp pt and all that
97 //masterPr->nextInstrPt = &&masterLoopStartPt;
100 //Note, got rid of writing the stack and frame ptr up here, because
101 // only one
102 // core can ever animate a given MasterVP, so don't need to communicate
103 // new frame and stack ptr to the MasterVP storage before a second
104 // version of that MasterVP can get animated on a different core.
105 //Also got rid of the busy-wait.
108 //masterLoopStartPt:
109 while(1){
111 //============================= MEASUREMENT STUFF ========================
112 #ifdef MEAS__TIME_MASTER
113 //Total Master time includes one coreloop time -- just assume the core
114 // loop time is same for Master as for AppVPs, even though it may be
115 // smaller due to higher predictability of the fixed jmp.
116 saveLowTimeStampCountInto( masterPr->startMasterTSCLow );
117 #endif
119 //========================================================================
121 masterEnv = (MasterEnv*)_VMSMasterEnv;
123 //GCC may optimize so doesn't always re-define from frame-storage
124 masterPr = (VirtProcr*)volatileMasterPr; //just to make sure after jmp
125 thisCoresIdx = masterPr->coreAnimatedBy;
126 readyToAnimateQ = masterEnv->readyToAnimateQs[thisCoresIdx];
127 schedSlots = masterEnv->allSchedSlots[thisCoresIdx];
129 requestHandler = masterEnv->requestHandler;
130 slaveScheduler = masterEnv->slaveScheduler;
131 semanticEnv = masterEnv->semanticEnv;
133 #ifdef MEAS__PERF_COUNTERS
134 CounterHandler counterHandler = masterEnv->counterHandler;
135 #endif
137 //Poll each slot's Done flag
138 numSlotsFilled = 0;
139 for( slotIdx = 0; slotIdx < NUM_SCHED_SLOTS; slotIdx++)
140 {
141 currSlot = schedSlots[ slotIdx ];
143 if( currSlot->workIsDone )
144 {
145 currSlot->workIsDone = FALSE;
146 currSlot->needsProcrAssigned = TRUE;
148 //process requests from slave to master
149 //====================== MEASUREMENT STUFF ===================
150 #ifdef MEAS__TIME_PLUGIN
151 int32 startStamp1, endStamp1;
152 saveLowTimeStampCountInto( startStamp1 );
153 #endif
154 #ifdef MEAS__PERF_COUNTERS
155 uint64 cycles, instrs;
156 saveCyclesAndInstrs(thisCoresIdx,cycles, instrs);
157 //(*counterHandler)(MasterLoop_beforeReqHdlr,currSlot->procrAssignedToSlot,cycles,instrs);
158 #endif
159 //============================================================
160 (*requestHandler)( currSlot->procrAssignedToSlot, semanticEnv );
161 //====================== MEASUREMENT STUFF ===================
162 #ifdef MEAS__TIME_PLUGIN
163 saveLowTimeStampCountInto( endStamp1 );
164 addIntervalToHist( startStamp1, endStamp1,
165 _VMSMasterEnv->reqHdlrLowTimeHist );
166 addIntervalToHist( startStamp1, endStamp1,
167 _VMSMasterEnv->reqHdlrHighTimeHist );
168 #endif
169 #ifdef MEAS__PERF_COUNTERS
170 //done with constraints check
171 uint64 cycles2,instrs2;
172 saveCyclesAndInstrs(thisCoresIdx,cycles2, instrs2);
173 (*counterHandler)(MasterLoop_afterReqHdlr,currSlot->procrAssignedToSlot,cycles2,instrs2);
174 #endif
175 //============================================================
176 }
177 if( currSlot->needsProcrAssigned )
178 { //give slot a new virt procr
179 #ifdef MEAS__PERF_COUNTERS
180 //start assigner
181 uint64 tmp_cycles;
182 uint64 tmp_instrs;
183 saveCyclesAndInstrs(thisCoresIdx,tmp_cycles,tmp_instrs);
184 //FIXME WTF AM I DOING WHY DOES THIS EVEN WORK
185 //(*counterHandler)(MasterLoop_beforeNextAssign,schedVirtPr,tmp_cycles,tmp_instrs);
186 #endif
187 schedVirtPr =
188 (*slaveScheduler)( semanticEnv, thisCoresIdx, slotIdx );
190 if( schedVirtPr != NULL )
191 { currSlot->procrAssignedToSlot = schedVirtPr;
192 schedVirtPr->schedSlot = currSlot;
193 currSlot->needsProcrAssigned = FALSE;
194 numSlotsFilled += 1;
196 writeVMSQ( schedVirtPr, readyToAnimateQ );
198 #ifdef MEAS__PERF_COUNTERS
199 uint64 cycles;
200 uint64 instrs;
201 saveCyclesAndInstrs(thisCoresIdx,cycles,instrs);
202 (*counterHandler)(MasterLoop_beforeAssign,schedVirtPr,tmp_cycles,tmp_instrs);
203 (*counterHandler)(MasterLoop_afterAssign,schedVirtPr,cycles,instrs);
204 #endif
205 }
206 }
208 }
211 #ifdef USE_WORK_STEALING
212 //If no slots filled, means no more work, look for work to steal.
213 if( numSlotsFilled == 0 )
214 { gateProtected_stealWorkInto( currSlot, readyToAnimateQ, masterPr );
215 }
216 #endif
219 #ifdef MEAS__TIME_MASTER
220 saveLowTimeStampCountInto( masterPr->endMasterTSCLow );
221 #endif
223 masterSwitchToCoreLoop(animatingPr);
224 flushRegisters();
225 }//MasterLoop
228 }
232 /*This has a race condition -- the coreloops are accessing their own queues
233 * at the same time that this work-stealer on a different core is trying to
234 */
235 void inline
236 stealWorkInto( SchedSlot *currSlot, VMSQueueStruc *readyToAnimateQ,
237 VirtProcr *masterPr )
238 {
239 VirtProcr *stolenPr;
240 int32 coreIdx, i;
241 VMSQueueStruc *currQ;
243 stolenPr = NULL;
244 coreIdx = masterPr->coreAnimatedBy;
245 for( i = 0; i < NUM_CORES -1; i++ )
246 {
247 if( coreIdx >= NUM_CORES -1 )
248 { coreIdx = 0;
249 }
250 else
251 { coreIdx++;
252 }
253 currQ = _VMSMasterEnv->readyToAnimateQs[coreIdx];
254 if( numInVMSQ( currQ ) > 0 )
255 { stolenPr = readVMSQ (currQ );
256 break;
257 }
258 }
260 if( stolenPr != NULL )
261 { currSlot->procrAssignedToSlot = stolenPr;
262 stolenPr->schedSlot = currSlot;
263 currSlot->needsProcrAssigned = FALSE;
265 writeVMSQ( stolenPr, readyToAnimateQ );
266 }
267 }
269 /*This algorithm makes the common case fast. Make the coreloop passive,
270 * and show its progress. Make the stealer control a gate that coreloop
271 * has to pass.
272 *To avoid interference, only one stealer at a time. Use a global
273 * stealer-lock.
274 *
275 *The pattern is based on a gate -- stealer shuts the gate, then monitors
276 * to be sure any already past make it all the way out, before starting.
277 *So, have a "progress" measure just before the gate, then have two after it,
278 * one is in a "waiting room" outside the gate, the other is at the exit.
279 *Then, the stealer first shuts the gate, then checks the progress measure
280 * outside it, then looks to see if the progress measure at the exit is the
281 * same. If yes, it knows the protected area is empty 'cause no other way
282 * to get in and the last to get in also exited.
283 *If the progress measure at the exit is not the same, then the stealer goes
284 * into a loop checking both the waiting-area and the exit progress-measures
285 * until one of them shows the same as the measure outside the gate. Might
286 * as well re-read the measure outside the gate each go around, just to be
287 * sure. It is guaranteed that one of the two will eventually match the one
288 * outside the gate.
289 *
290 *Here's an informal proof of correctness:
291 *The gate can be closed at any point, and have only four cases:
292 * 1) coreloop made it past the gate-closing but not yet past the exit
293 * 2) coreloop made it past the pre-gate progress update but not yet past
294 * the gate,
295 * 3) coreloop is right before the pre-gate update
296 * 4) coreloop is past the exit and far from the pre-gate update.
297 *
298 * Covering the cases in reverse order,
299 * 4) is not a problem -- stealer will read pre-gate progress, see that it
300 * matches exit progress, and the gate is closed, so stealer can proceed.
301 * 3) stealer will read pre-gate progress just after coreloop updates it..
302 * so stealer goes into a loop until the coreloop causes wait-progress
303 * to match pre-gate progress, so then stealer can proceed
304 * 2) same as 3..
305 * 1) stealer reads pre-gate progress, sees that it's different than exit,
306 * so goes into loop until exit matches pre-gate, now it knows coreloop
307 * is not in protected and cannot get back in, so can proceed.
308 *
309 *Implementation for the stealer:
310 *
311 *First, acquire the stealer lock -- only cores with no work to do will
312 * compete to steal, so not a big performance penalty having only one --
313 * will rarely have multiple stealers in a system with plenty of work -- and
314 * in a system with little work, it doesn't matter.
315 *
316 *Note, have single-reader, single-writer pattern for all variables used to
317 * communicate between stealer and victims
318 *
319 *So, scan the queues of the core loops, until find non-empty. Each core
320 * has its own list that it scans. The list goes in order from closest to
321 * furthest core, so it steals first from close cores. Later can add
322 * taking info from the app about overlapping footprints, and scan all the
323 * others then choose work with the most footprint overlap with the contents
324 * of this core's cache.
325 *
326 *Now, have a victim want to take work from. So, shut the gate in that
327 * coreloop, by setting the "gate closed" var on its stack to TRUE.
328 *Then, read the core's pre-gate progress and compare to the core's exit
329 * progress.
330 *If same, can proceed to take work from the coreloop's queue. When done,
331 * write FALSE to gate closed var.
332 *If different, then enter a loop that reads the pre-gate progress, then
333 * compares to exit progress then to wait progress. When one of two
334 * matches, proceed. Take work from the coreloop's queue. When done,
335 * write FALSE to the gate closed var.
336 *
337 */
338 void inline
339 gateProtected_stealWorkInto( SchedSlot *currSlot,
340 VMSQueueStruc *myReadyToAnimateQ,
341 VirtProcr *masterPr )
342 {
343 VirtProcr *stolenPr;
344 int32 coreIdx, i, haveAVictim, gotLock;
345 VMSQueueStruc *victimsQ;
347 volatile GateStruc *vicGate;
348 int32 coreMightBeInProtected;
352 //see if any other cores have work available to steal
353 haveAVictim = FALSE;
354 coreIdx = masterPr->coreAnimatedBy;
355 for( i = 0; i < NUM_CORES -1; i++ )
356 {
357 if( coreIdx >= NUM_CORES -1 )
358 { coreIdx = 0;
359 }
360 else
361 { coreIdx++;
362 }
363 victimsQ = _VMSMasterEnv->readyToAnimateQs[coreIdx];
364 if( numInVMSQ( victimsQ ) > 0 )
365 { haveAVictim = TRUE;
366 vicGate = _VMSMasterEnv->workStealingGates[ coreIdx ];
367 break;
368 }
369 }
370 if( !haveAVictim ) return; //no work to steal, exit
372 //have a victim core, now get the stealer-lock
373 gotLock =__sync_bool_compare_and_swap( &(_VMSMasterEnv->workStealingLock),
374 UNLOCKED, LOCKED );
375 if( !gotLock ) return; //go back to core loop, which will re-start master
378 //====== Start Gate-protection =======
379 vicGate->gateClosed = TRUE;
380 coreMightBeInProtected= vicGate->preGateProgress != vicGate->exitProgress;
381 while( coreMightBeInProtected )
382 { //wait until sure
383 if( vicGate->preGateProgress == vicGate->waitProgress )
384 coreMightBeInProtected = FALSE;
385 if( vicGate->preGateProgress == vicGate->exitProgress )
386 coreMightBeInProtected = FALSE;
387 }
389 stolenPr = readVMSQ ( victimsQ );
391 vicGate->gateClosed = FALSE;
392 //======= End Gate-protection =======
395 if( stolenPr != NULL ) //victim could have been in protected and taken
396 { currSlot->procrAssignedToSlot = stolenPr;
397 stolenPr->schedSlot = currSlot;
398 currSlot->needsProcrAssigned = FALSE;
400 writeVMSQ( stolenPr, myReadyToAnimateQ );
401 }
403 //unlock the work stealing lock
404 _VMSMasterEnv->workStealingLock = UNLOCKED;
405 }